Skip to content

Log previous and new value of configuration when reset/update API is called #10769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Log previous and new value of configuration when reset/update API is called #10769

wants to merge 2 commits into from
+61 −36

Conversation

sudo87
Copy link
Collaborator

@sudo87 sudo87 commented Apr 24, 2025

Description

This PR handles #5 scenario mentioned in #6880
During reset and update configuration, system will log existing and incoming value.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screenshot from 2025-04-22 18-09-00

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sudo87 sudo87 changed the title Log previous and new value of configuration before reset/update Log previous and new value of configuration when reset/update API is called Apr 24, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 41.46341% with 24 lines in your changes missing coverage. Please review.

Project coverage is 16.32%. Comparing base (193d6ef) to head (74a00c4).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
.../cloud/configuration/ConfigurationManagerImpl.java 41.46% 18 Missing and 6 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff            @@
##               main   #10769   +/-   ##
=========================================
  Coverage     16.31%   16.32%           
- Complexity    13463    13468    +5     
=========================================
  Files          5676     5676           
  Lines        499391   499434   +43     
  Branches      60397    60397           
=========================================
+ Hits          81485    81519   +34     
+ Misses       408834   408833    -1     
- Partials       9072     9082   +10
Flag Coverage Δ
uitests 3.99% <ø> (+<0.01%) ⬆️
unittests 17.18% <41.46%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shwstppr
Copy link
Contributor

@blueorangutan package

@blueorangutan
Copy link

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13162

@sudo87
Following changes are done in this commit:
74a00c4 
1. Change type for scope paramter for method updateConfiguration and validateConfigurationValue
2. Standardize scope variable to be of ConfigKey type and scopeVal as string
@sudo87 sudo87 requested a review from DaanHoogland April 24, 2025 11:33
DaanHoogland
DaanHoogland approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@sudo87
Copy link
Collaborator Author

sudo87 commented Apr 24, 2025

@blueorangutan package

@blueorangutan
Copy link

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13168

@DaanHoogland
Copy link
Contributor

@blueorangutan test

@blueorangutan
Copy link

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

shwstppr
shwstppr approved these changes May 12, 2025
View reviewed changes
Copy link
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@blueorangutan
Copy link

[SF] Trillian test result (tid-13269)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 56812 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10769-t13269-kvm-ol8.zip
Smoke tests completed. 124 look OK, 17 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_2FA_enabled Error 0.03 test_2fa.py
test_2FA_setup Error 0.03 test_2fa.py
test_UpdateConfigParamWithScope Error 0.06 test_global_settings.py
test_UpdateConfigParamWithScope Error 0.06 test_global_settings.py
test_01_deploy_vm_with_extraconfig_throws_exception_kvm Error 0.04 test_deploy_vm_extra_config_data.py
test_02_deploy_vm_with_extraconfig_kvm Error 0.04 test_deploy_vm_extra_config_data.py
test_03_update_vm_with_extraconfig_kvm Error 0.05 test_deploy_vm_extra_config_data.py
test_04_deploy_vm_with_extraconfig_throws_exception_vmware Error 0.04 test_deploy_vm_extra_config_data.py
test_05_deploy_vm_with_extraconfig_vmware Error 0.03 test_deploy_vm_extra_config_data.py
test_06_deploy_vm_with_extraconfig_throws_exception_xenserver Error 0.03 test_deploy_vm_extra_config_data.py
test_07_deploy_vm_with_extraconfig_xenserver Error 0.03 test_deploy_vm_extra_config_data.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces Error 2.40 test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces Error 2.43 test_internal_lb.py
test_01_disable_account_settings_for_domain Error 8.62 test_enable_account_settings_for_domain.py
test_02_enable_account_settings_for_domain Error 9.35 test_enable_account_settings_for_domain.py
test_03_enable_account_settings_for_domain Error 8.34 test_enable_account_settings_for_domain.py
test_01_auto_enable_disable_kvm_host Error 0.11 test_host_control_state.py
test_02_disable_host_overrides_auto_enable_kvm_host Error 0.10 test_host_control_state.py
test_03_enable_host_does_not_override_auto_disable_kvm_host Error 0.10 test_host_control_state.py
ContextSuite context=TestMetrics>:setup Error 0.00 test_metrics_api.py
test_01_non_strict_host_anti_affinity Failure 146.08 test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity Error 87.28 test_nonstrict_affinity_group.py
test_01_add_primary_storage_disabled_host Error 40.10 test_primary_storage.py
test_01_primary_storage_scope_change Error 0.11 test_primary_storage_scope.py
test_another_user_can_allocate_ip_after_quarantined_has_ended_network Error 9.09 test_quarantined_ips.py
test_another_user_can_allocate_ip_after_quarantined_has_ended_vpc Error 0.45 test_quarantined_ips.py
test_only_owner_can_allocate_ip_in_quarantine_network Error 0.52 test_quarantined_ips.py
test_only_owner_can_allocate_ip_in_quarantine_vpc Error 0.50 test_quarantined_ips.py
ContextSuite context=TestScaleVm>:teardown Error 0.03 test_scale_vm.py
test_01_sys_vm_start Failure 0.13 test_secondary_storage.py
ContextSuite context=TestCpuCapServiceOfferings>:setup Error 0.00 test_service_offerings.py
ContextSuite context=TestVmAutoScaling>:setup Error 0.00 test_vm_autoscaling.py
test_01_deploy_vm_on_specific_host Error 0.11 test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster Error 0.15 test_vm_deployment_planner.py
test_02_restore_vm_strict_tags_failure Failure 54.72 test_vm_strict_host_tags.py
test_02_scale_vm_strict_tags_failure Failure 59.98 test_vm_strict_host_tags.py
test_06_deploy_vm_on_any_host_with_strict_tags_failure Failure 6.83 test_vm_strict_host_tags.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shwstppr shwstppr shwstppr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees
No one assigned
Labels
component:vpc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sudo87 @shwstppr @blueorangutan @DaanHoogland